search

kiwix / kiwix-js

Fully portable & lightweight ZIM reader in Javascript
https://www.kiwix.org/
GNU General Public License v3.0
311 stars 135 forks source link

Add i189 for Chromium store entries #1271

Closed Jaifroid closed 4 months ago

Jaifroid commented 4 months ago

Fixes #1118. According to the messages I receive when uploading an extension to the Edge or Chrome Stores, in order to internationalize the Store entry it is necessary to internationalize the manifests, adding those languages supported by the app. I've followed https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Internationalization, but I don't know for sure that this will do the trick until I attempt to upload the generated extension ZIPs.

We don't use the Chrome i18n module for i18n within the app, as we use a much simpler string-substitution system, and I'm not going to change that any time soon, especially as i18n for this app needs to work in multiple contexts, not just extensions.

Jaifroid commented 4 months ago

Thanks, I'm going to see if I can do a test draft upload from this branch to the Edge Store to see if this actually does the job I want it to do...

Jaifroid commented 4 months ago

Hmm, something is wrong uploading and zipping the _locales directory. I'll debug tomorrow.

Jaifroid commented 4 months ago

LOL, I forgot to add the _locales directory in the rollup config, doh...

Jaifroid commented 4 months ago

Yay, it works, finally!

image

Now I just have to work out why the "Description" field is empty when I thought included it....

Jaifroid commented 4 months ago

OK, so description in Edge Store at least isn't taken from the manifest, so I think this PR is complete now.