search

kiwix / kiwix-tools

Command line Kiwix tools: kiwix-serve, kiwix-manage, ...
https://download.kiwix.org/release/kiwix-tools/
GNU General Public License v3.0
462 stars 87 forks source link

kiwix-serve showing broken images #340

Closed metal450 closed 5 years ago

metal450 commented 5 years ago

kiwix-serve is showing broken images for many articles, which work properly in Kiwix Desktop, Kiwix Android, etc.

Repro: 1) Download the latest Kiwix Desktop for Windows (kiwix-desktop_windows_x64_2.0-rc3 at the time of writing). 2) Download wikivoyage_en_all_maxi_2019-10.zim from https://wiki.kiwix.org/wiki/Content_in_all_languages 3) Launch Kiwix Desktop. File->Open file->select the zim. 4) Search for Osaka/Kita. Note that the article & images work. Screenshot: 2019-10-04_18 42 27

5) Local Kiwix Server->Start Kiwix Server->Open in browser. 6) First, try just viewing the main Osaka article. Note that images work. Screenshot: 2019-10-04_18 42 27

7) Now try Osaka/Kita. Images are broken. Screenshot:

2019-10-04_18 42 53

kelson42 commented 5 years ago

Strange, works fine online http://library.kiwix.org/wikivoyage_en_all_maxi/A/Osaka/Kita. File and kiwix-serve seem to be OK.

kelson42 commented 5 years ago

@metal450 Thank you for reporting this, the problem is with the ZIM file itself I guess. The bug is tracked here https://github.com/openzim/mwoffliner/issues/726

kelson42 commented 5 years ago

I will close this ticket as this is basically a duplicate but thx again for reporting.

metal450 commented 4 years ago

I don't think this should be closed.

You mention it's the zim file itself, but the same zim works perfectly in Kiwix Desktop for Windows, and Kiwix 0.9, and Kiwix Android. Above was just one example of the issue for the purpose of being able to reproduce it - but I have many zims and I can use all of them on all other clients; they only fail on kiwix-serve. This includes zims I've built myself by other means (i.e. https://github.com/vss-devel/zimmer).

I was attempting to move from Kiwix 0.9 to kiwix-serve, but couldn't because kiwix-serve fails on the majority of my library. So even if there's an issue in mwofflin, I don't think this is a duplicate. It seems like kiwix-serve should be able to handle the data that's handled by all the other clients.

kelson42 commented 4 years ago

@metal450 I would be happy to reopen the ticket if we have a recent file (wikivoyage_en_all_maxi_2019-10.zim is not online anymore) with a concrete article with a concrete image which works on Kiwix-Desktop and not on Kiwix-serve. Of course Kiwix Desktop 0.9 being deprecated, I talk about Kiwix Desktop 2.0.

metal450 commented 4 years ago

Wait, actually, apologies - I take that back. It looks like if I re-download newer version of all the zims that are available online, they do work; the ones that don't (i.e. that work in 0.9 & Android, but not in kiwix-serve) also don't work in Desktop, & those are only the ones that were generated by zimmer. So I stand corrected, looks like this issue is indeed fixed - the pending one is actually https://github.com/kiwix/kiwix-desktop/issues/270 :)