Add support for ARM in Docker

kiwix / kiwix-tools

Command line Kiwix tools: kiwix-serve, kiwix-manage, ...

https://download.kiwix.org/release/kiwix-tools/

GNU General Public License v3.0

435 stars 85 forks source link

Add support for ARM in Docker #404

Closed grahamalderson closed 4 years ago

grahamalderson commented 4 years ago

Add support for ARM 32 bit architecture to Docker build to support Raspberry Pi

kelson42 commented 4 years ago

@grahamalderson Thank you for your PR. I'm not 100% convinced about the value of the PR because:

not sure do understand the use case
level of code duplication with the other Dockerfile
Not sure about the integration with the Hub.docker.com

@rgaudin Any thoughs?

grahamalderson commented 4 years ago

Thanks for the quick reply @kelson42. I believe the extra Dockerfile is required in order to enable multi-architecture Docker containers. By adding this file, the Docker build can support both x86_64 and armhf architectures. It is quite similar to the original Dockerfile because the only required change is choosing the correct version of kiwix.

rgaudin commented 4 years ago

This can be achieved with a --build-arg. See #405. I never used that with docker hub so not sure how that would work.

grahamalderson commented 4 years ago

Great! #405 seems much more elegant. Closing in favor of the better solution.