search

kiwix / kiwix-tools

Command line Kiwix tools: kiwix-serve, kiwix-manage, ...
https://download.kiwix.org/release/kiwix-tools/
GNU General Public License v3.0
461 stars 87 forks source link

& in the suggestions gets to & in the search field #453

Closed JensKorte closed 3 years ago

JensKorte commented 3 years ago

Using kiwix-serve x86_64-3.1.2-4, wikipedia-de and Firefox I search for "Übel " and get the suggestions:

If I click on "Übel & gefährlich" in the search field appears "Übel \& gefährlich" and a full text search is done, instead of leading me to page "Übel & gefährlich".

mgautierfr commented 3 years ago

Related to https://github.com/openzim/libzim/issues/536

@maneeshpm can you confirm this is the same issue and it is fixed ?

maneeshpm commented 3 years ago

@mgautierfr This issue seems a bit different. We can be sure that openzim/libzim#536 is fixed since the we are getting proper suggestions. As reported, the issue occurs when we click the "containing ...string..." option. I feel this is an HTML encoding issue with the form and might be related to this.

kelson42 commented 3 years ago

@maneeshpm So you can reproduce the problem with developement kiwix-serve?

maneeshpm commented 3 years ago

@kelson42 Yes, It's there in the latest kiwix-lib master.

maneeshpm commented 3 years ago

@kelson42 I think the issue has been fixed. I tried to recreate the issue after clearing my browser cache and the issue was gone. @JensKorte can you confirm?

JensKorte commented 3 years ago

@maneeshpm I am compiling all the dependencies and can't give a fast reply.

JensKorte commented 3 years ago

@maneeshpm I guess somewhere missed to include the libs that suggestions work for me. I give up compiling it on my own. If there is a release or a rc I will try it.

maneeshpm commented 3 years ago

Ohk @JensKorte, please keep us posted.

@kelson42 I cannot reproduce this bug anymore, we can close this issue now.