search

kiwix / kiwix-tools

Command line Kiwix tools: kiwix-serve, kiwix-manage, ...
https://download.kiwix.org/release/kiwix-tools/
GNU General Public License v3.0
461 stars 87 forks source link

kiwix-serve does not display a startup message after invocation #473

Closed suterma closed 2 years ago

suterma commented 3 years ago

Problem After invocation from the command line, kiwix-serve is not producing an console message, not even in the --verbose mode.

Expected behavior After successful startup, a message like kiwix is running. Start browsing the library at http://192.168.12.78:8080 should be displayed, also in non-verbose mode.

Steps to reproduce the behavior: Just start kiwix-serve, e.g. using $ ./kiwix-serve --library ~/.local/share/kiwix/library.xml --port=8080 --verbose

Screenshots n/a

Environment

kelson42 commented 3 years ago

I’m not sure I want to have this is non verbose mode, but yes for the verbose mode.

mgautierfr commented 3 years ago

It agree with this. And I think it is ok to have this in non verbose mode. It is a legitimate information to have in normal mode.

A time ago we were parsing the zim file at startup and kiwix-serve spend few time before being ready. Having a small message would have been a good thing.

kelson42 commented 3 years ago

Blocked by https://github.com/kiwix/libkiwix/issues/613

mgautierfr commented 3 years ago

It is not really blocked by kiwix/libkiwix#613. For now we are binding to all interfaces. We can simply use "127.0.0.1" as default address when we print the message.

kelson42 commented 2 years ago

@juuz0 Now that https://github.com/kiwix/libkiwix/pull/622 exposes the necessay material, would you be able to use it to fix this? We don’t need to wait that your libkiwix PR is merged.

juuz0 commented 2 years ago

@kelson42 Yes :+1: