Closed veloman-yunkan closed 2 years ago
@kelson42
In kiwix-tools, the deprecated libkiwix API was used only in kiwix-search
and kiwix-reader
.
kiwix-search
is now clean.
Regarding kiwix-reader
, do we need to keep it at all? Its name is misleading, since it is rather a variant of kiwix-search --suggest
that works with some heuristic on old ZIM files without a title index.
@veloman-yunkan It seems we can delete kiwix-reader
and actually there is already a requea]st to remove kiwix-search
now that all the logic in at the libzim level, see https://github.com/openzim/zim-tools/issues/262.
Can you remove the redundant line at src/searcher/kiwix-search.cpp#L117 has shown by codefactor.io ?
Else we are good (No need to ask for a second review once it is fixed)
Done
Fixes #533