search

kiwix / kiwix-tools

Command line Kiwix tools: kiwix-serve, kiwix-manage, ...
https://download.kiwix.org/release/kiwix-tools/
GNU General Public License v3.0
428 stars 83 forks source link

Add iostream header and namespace std #564

Closed juuz0 closed 2 years ago

juuz0 commented 2 years ago

Previously, there was an inconsistent usage of no namespace vs namespace. This change fixes that by correctly adding std:: whenever required. Adds iostream header in src/version.h to fix cout/cerr problems. Fixes #563

juuz0 commented 2 years ago

Needs https://github.com/kiwix/libkiwix/pull/794 merged, to pass CI checks

juuz0 commented 2 years ago

The CI still fails, why?

mgautierfr commented 2 years ago

The CI still fails, why?

The fix on libkiwix has been merged, but the kiwix-build nightly which build the dependencies for kiwix-tools (and so build libkiwix) has not yet run. So we are still compiling kiwix-tools with yesterday master.

Let's wait tomorow before merging this PR to be sure that libkiwix fix is ok