search

kiwix / kiwix-tools

Command line Kiwix tools: kiwix-serve, kiwix-manage, ...
https://download.kiwix.org/release/kiwix-tools/
GNU General Public License v3.0
408 stars 79 forks source link

iframe defaults to height: 150px; in older browsers #592

Closed ghost closed 1 year ago

ghost commented 1 year ago

Using an older browser the iframe that serves the content is only set to 150px high, making the content difficult to read.

This works:

This does not:

However there is something in the kiwix webpage that doesn't work when I try appending height:100% to the iframe element. I don't know why.

kelson42 commented 1 year ago

@tim78245 Which exact version of seamonkey do you use? We need to reproduce the bug first.

kelson42 commented 1 year ago

This CSS spec is interesting https://www.w3.org/TR/CSS2/visudet.html#inline-replaced-height

ghost commented 1 year ago

@tim78245 Which exact version of seamonkey do you use? We need to reproduce the bug first.

the current version, 2.53.14.

This CSS spec is interesting https://www.w3.org/TR/CSS2/visudet.html#inline-replaced-height

Yes, 150px is the default.

kelson42 commented 1 year ago

@veloman-yunkan Could you please make this quick fix?

veloman-yunkan commented 1 year ago

kiwix/libkiwix#871 made the situation for seamonkey even worse (see https://github.com/kiwix/libkiwix/pull/871#issuecomment-1420485032). I will try to make seamonkey happy with kiwix-serve's ZIM viewer again.

veloman-yunkan commented 1 year ago

Regarding the wrong height of the iframe - the root cause is because seamonkey doesn't recognize window.visualViewport:

TypeError: window.visualViewport is undefined[Learn More]  viewer.js:187:3
  handle_visual_viewport_change http://localhost:8080/ROOT/skin/viewer.js:187:3
kelson42 commented 1 year ago

@veloman-yunkan So, it's a WONTFIX? Uers have to use a recent browser?

veloman-yunkan commented 1 year ago

@veloman-yunkan So, it's a WONTFIX? Uers have to use a recent browser?

No. I have already fixed (or rather worked around) the issue reported in this ticket, but it won't make any difference until kiwix/libkiwix#885 is fixed too (which I am working on now).