kiwix / kiwix-tools

Command line Kiwix tools: kiwix-serve, kiwix-manage, ...
https://download.kiwix.org/release/kiwix-tools/
GNU General Public License v3.0
443 stars 85 forks source link

Added missing parameters to kiwix-serve.1 #626

Closed iArchitSharma closed 1 year ago

iArchitSharma commented 1 year ago

Fixes #609

kelson42 commented 1 year ago

@iArchitSharma Thank you for your PR, we will do our best to review it quickly!

iArchitSharma commented 1 year ago

@veloman-yunkan I have updated the manpage, is it good now?

iArchitSharma commented 1 year ago

@veloman-yunkan Done with everything you told!

iArchitSharma commented 1 year ago

@veloman-yunkan Is it good now?

iArchitSharma commented 1 year ago

You misunderstood one of my previous comments. After you fix it please squash all your commits into one and the PR will be good to merge.

Can you tell me how I can squash all of my commits? I searched the web, but it didn't help.

veloman-yunkan commented 1 year ago

@veloman-yunkan Is it good now?

It is a little short of being good:

  1. There is no --library option in the first version of kiwix-serve invocation.
  2. The two versions of kiwix-serve invocation appear on a single line.

Screenshot from 2023-07-11 19-05-36

veloman-yunkan commented 1 year ago

Can you tell me how I can squash all of my commits? I searched the web, but it didn't help.

Use interactive git rebase

veloman-yunkan commented 1 year ago

@veloman-yunkan Is it good now?

It is a little short of being good:

  1. There is no --library option in the first version of kiwix-serve invocation.

  2. The two versions of kiwix-serve invocation appear on a single line.

Screenshot from 2023-07-11 19-05-36

Also LIBRARY_FILE_PATH and/or ZIM_FILE_PATH arguments are not optional. Why don't you literally reproduce the text found in the online documentation and/or my previous comment?

iArchitSharma commented 1 year ago

@veloman-yunkan done!

iArchitSharma commented 1 year ago

Can you tell me how I can squash all of my commits? I searched the web, but it didn't help.

Use interactive git rebase

still not able to, can you merge without me stashing all the commits?

kelson42 commented 1 year ago

@iArchitSharma No, because this will pollute the git revision log. What is the problem? You don't use git on the command line?

iArchitSharma commented 1 year ago

@iArchitSharma No, because this will pollute the git revision log. What is the problem? You don't use git on the command line?

I use git but have never squashed before this is the command i should be using right - git rebase -i <commit> should i pass the first commit or last commit i made in <commit>

iArchitSharma commented 1 year ago

Finally done with squash too!

veloman-yunkan commented 1 year ago

Finally done with squash too!

But the result is still not available on GitHub. Note that you have to provide the --force option to git push after you rewrite the commit history.

veloman-yunkan commented 1 year ago

@veloman-yunkan Is it good now?

It is a little short of being good:

  1. There is no --library option in the first version of kiwix-serve invocation.

  2. The two versions of kiwix-serve invocation appear on a single line.

Screenshot from 2023-07-11 19-05-36

Item 2 was not addressed.

iArchitSharma commented 1 year ago

@veloman-yunkan Is it good now?

It is a little short of being good:

  1. There is no --library option in the first version of kiwix-serve invocation.
  2. The two versions of kiwix-serve invocation appear on a single line.

Screenshot from 2023-07-11 19-05-36

Item 2 was not addressed.

Done

iArchitSharma commented 1 year ago

Finally done with squash too!

But the result is still not available on GitHub. Note that you have to provide the --force option to git push after you rewrite the commit history.

All done!

iArchitSharma commented 1 year ago

Thanks for bearing with me!

I really appreciate your assistance. I've learned a lot