Closed iArchitSharma closed 1 year ago
@iArchitSharma Thank you for your PR, we will do our best to review it quickly!
@veloman-yunkan I have updated the manpage, is it good now?
@veloman-yunkan Done with everything you told!
@veloman-yunkan Is it good now?
You misunderstood one of my previous comments. After you fix it please squash all your commits into one and the PR will be good to merge.
Can you tell me how I can squash all of my commits? I searched the web, but it didn't help.
@veloman-yunkan Is it good now?
It is a little short of being good:
--library
option in the first version of kiwix-serve
invocation.kiwix-serve
invocation appear on a single line.Can you tell me how I can squash all of my commits? I searched the web, but it didn't help.
@veloman-yunkan Is it good now?
It is a little short of being good:
There is no
--library
option in the first version ofkiwix-serve
invocation.The two versions of
kiwix-serve
invocation appear on a single line.
Also LIBRARY_FILE_PATH
and/or ZIM_FILE_PATH
arguments are not optional. Why don't you literally reproduce the text found in the online documentation and/or my previous comment?
@veloman-yunkan done!
Can you tell me how I can squash all of my commits? I searched the web, but it didn't help.
still not able to, can you merge without me stashing all the commits?
@iArchitSharma No, because this will pollute the git revision log. What is the problem? You don't use git on the command line?
@iArchitSharma No, because this will pollute the git revision log. What is the problem? You don't use git on the command line?
I use git but have never squashed before
this is the command i should be using right - git rebase -i <commit>
should i pass the first commit or last commit i made in <commit>
Finally done with squash too!
Finally done with squash too!
But the result is still not available on GitHub. Note that you have to provide the --force
option to git push
after you rewrite the commit history.
@veloman-yunkan Is it good now?
It is a little short of being good:
There is no
--library
option in the first version ofkiwix-serve
invocation.The two versions of
kiwix-serve
invocation appear on a single line.
Item 2 was not addressed.
@veloman-yunkan Is it good now?
It is a little short of being good:
- There is no
--library
option in the first version ofkiwix-serve
invocation.- The two versions of
kiwix-serve
invocation appear on a single line.Item 2 was not addressed.
Done
Finally done with squash too!
But the result is still not available on GitHub. Note that you have to provide the
--force
option togit push
after you rewrite the commit history.
All done!
Thanks for bearing with me!
I really appreciate your assistance. I've learned a lot
Fixes #609