search

kiwix / kiwix-tools

Command line Kiwix tools: kiwix-serve, kiwix-manage, ...
https://download.kiwix.org/release/kiwix-tools/
GNU General Public License v3.0
407 stars 79 forks source link

Add IPv6 support to Kiwix Server #673

Closed aryanA101a closed 1 month ago

aryanA101a commented 2 months ago

Fixes #545

depends on https://github.com/kiwix/libkiwix/pull/1074

kelson42 commented 1 month ago

@aryanA101a Now that https://github.com/kiwix/libkiwix/pull/1074 is (almost) ready, we should focus on this PR. Is this PR ready for a new review? Could you please give a specific feedback to each comment of the reviewer?

kelson42 commented 1 month ago

@aryanA101a Can we complete this PR?

aryanA101a commented 1 month ago

I'm not sure why the build is failing. Is it due to dpkg-buildpackage does something different? https://github.com/kiwix/kiwix-tools/actions/runs/9188369878/job/25571181092?pr=673#step:9:432 Perhaps it is not linking with libkiwix.so

kelson42 commented 1 month ago

@aryanA101a This is something out of the scope of this PR. I'm more concerned about the fact that other parts of the CI (like compilation on Linux) is not triggered at all!

mgautierfr commented 1 month ago

I'm more concerned about the fact that other parts of the CI (like compilation on Linux) is not triggered at all!

Should be fixed by #679

veloman-yunkan commented 1 month ago

Since I actually performed the proposed changes locally (in order to find out the proper formatting of documentation) I also committed them. If you are fine with them, please rebase&fix-up and we will merge this PR.

kelson42 commented 1 month ago

@aryanA101a Please squash everything in one commit