search

kiwix / kiwix-xulrunner

[ARCHIVED] Legacy Kiwix desktop solution for Windows/macOS/Linux
https://download.kiwix.org/release/kiwix-xulrunner/
GNU General Public License v3.0
112 stars 28 forks source link

Android Bookmarks should save the ZIM metadata "name" (if available) #305

Closed kelson42 closed 7 years ago

kelson42 commented 8 years ago

I have implemented last WE the support of the ZIM metadata "name". The name being a string which is table over ZIM revisions. Using it should allow to keep the bookmarks even after a ZIM file update. If available this name should be taken instead of the ZIM file name (or UUIS, not sure what is use currently). For now, I do not have published officially ZIM files with this metadata, but I have provided a demo file which can be used for dev purposes here: http://tmp.kiwix.org/zim%2bftindex/wikipedia_bm_all_nopic_2016-09.zim.

kelson42 commented 8 years ago

@EladKeyshawn The first ZIM files with this new tags have been created and in library.xml.

EladKeyshawn commented 8 years ago

@kelson42 In the code the bookmark entity contains "ZIM id" not "name", I guess its the same meaning. but just confirming that with you.

kelson42 commented 8 years ago

@EladKeyshawn no the ZIM id is a unique identifier for a ZIM file, the ZIM name is permanent over revisions of the file http://www.openzim.org/wiki/Metadata.

EladKeyshawn commented 8 years ago

@kelson42 Yeah, first of all in the page you sent there name and title, did not see any id. But of course, there should be a unique id per zim. Anyways I need to know if all zim files now provide a name?

kelson42 commented 8 years ago

@EladKeyshawn no, do not assume they will, use the current solution as a fallback.

mhutti1 commented 8 years ago

@EladKeyshawn Be sure to checkout ade6aed3623381a8a1d410b7b314c34a812b0080 for any conflicts. I don't think there would be but better safe than sorry.

mhutti1 commented 7 years ago

Part 1: Steps to reproduce:

  1. Download a ZIM file through our app.
  2. Bookmark a page.

What you get:

What we want:

This should be achived by: