kiwix / kiwix-xulrunner

[ARCHIVED] Legacy Kiwix desktop solution for Windows/macOS/Linux
https://download.kiwix.org/release/kiwix-xulrunner/
GNU General Public License v3.0
111 stars 28 forks source link

Android library XML url should be updated #309

Closed kelson42 closed 8 years ago

kelson42 commented 8 years ago

It's currentl http://www.kiwix.org/library.xml and it should https://download.kiwix.org/library/library.xml

The old one should still work, but we slowly become deprecated.

mhutti1 commented 8 years ago

This is proving to be tricky. I don't think retrofit likes the redirect :(

mhutti1 commented 8 years ago

It seems as well as the redirect issue the way we currently handle the XML fails if the schema is not what it is expecting. It was not expecting the fields name and tags. This was what was causing retrofit to crash and the no network error to appear.

mhutti1 commented 8 years ago

@kelson42 As a warning I just one to say that editing the formatting of the download XML or adding attributes could cause the app to be unable to access downloads in the future and as such from this point onward we would need to come up with some solution to this.

kelson42 commented 8 years ago

@mhutti1 this is a problem if we can not add fields without breaking the android app. Any chance to get rid of this problem?

mhutti1 commented 8 years ago

I will try but it might be an issue with the library we are using. Hopefully I might be able to at least give the user a more helpful error message.