Improve displaying of storage device list on Android

kiwix / kiwix-xulrunner

[ARCHIVED] Legacy Kiwix desktop solution for Windows/macOS/Linux

https://download.kiwix.org/release/kiwix-xulrunner/

GNU General Public License v3.0

112 stars 28 forks source link

Improve displaying of storage device list on Android #327

Closed kelson42 closed 7 years ago

kelson42 commented 8 years ago

Currently "Settings" > "Storage" list displays only (1) and (2):

3.8
53.7

I think it should looks like:

Internal memory: 3.8GB free (from 16GB)
External memory: 53.GB free (from 128GB)

mhutti1 commented 7 years ago

@kelson42 I think this should now work almost correctly (although the naming of devices is not 100% accurate as there is no way to tell if getExternalStorage is returning internal or external storage)

kelson42 commented 7 years ago

@mhutti1 Here a few remarks after testing:

I do not understand what "Default" means, it seems to be a duplicate of "Private", so I would delete it.
"Private" seems to mean "Internal" stroage, if this is the case, I would rename it that way.
I would round the the number to only on digit after comma (will look simplier).
I would remove the ":" in the list, that looks easy enough to understand without them.
On the "Settings" panel, I would replace "Current Folder" by "External" or "Internal".

mhutti1 commented 7 years ago

@kelson42

What I have got it displaying is the fewest duplicate devices that also minimises the risk of not detecting devices. There is no way for us to tell if default is on another device or not. Because of this we must have it separate to private otherwise we risk not identifying a device.
Private does not mean internal storage as there is no concept of internal / external storage just manufacturer implemented suggestions. Private means only our app can access it. This is very likely to be internal but we call it private to distinguish from default which may be internal or external.
and
Yeah I can do this.
This should also be possible but using Private/Default/External

mhutti1 commented 7 years ago

@kelson42 After looking into it it is impossible to do as we agreed in IRC because for example internal storage is mounted to /sdcard on my nexus 5x. Android thinks this is external. It has no concept of if its internal or external. As such as far as I am aware there is no way to tell. As such I think its best to rename external to shared as that is the only think that we know that it is.

mhutti1 commented 7 years ago

@kelson42 Ok so I have come up with a solution. I am not sure if it will work for sure but we can give it a shot and test on some devices.

kelson42 commented 7 years ago

@mhutti1 Great, I will have a look this evening!

kelson42 commented 7 years ago

@mhutti1 Looks good to me now, let see if our users enjoy it too. Well done!