Closed mhutti1 closed 7 years ago
I have actually got much further much faster than I thought I could. Although still a prototype I have successfully implemented multizim search with only a few issues.
https://github.com/kiwix/kiwix/tree/android_multizim_search
At the moment I can see 3 potential issues.
First, memory:
The additional searching has made searches take considerably longer as such:
Files with duplicate titles currently default to the physically open zim file.
In addition to this currently to load the multizims a user must visit the content management screen. We should remove this requirement (and implement functions to allow the adding of additional readers to the array without swapping the current reader out)
PS: I am a complete C++ novice as such my code may be dreadful, feel free to point out any flaws.
1 - This should be first optional IMO 2 - On iOS, the user can choose which ZIM file to include in the search (which allow to make it quicker if the whole stuff is too slow).
I'll have a look in detail to your code.
This issue was moved to kiwix/kiwix-android#54
We should implement multizim search as in the IOS app into the android app.
The ZIM files that are searchable should be a user selected subset of the available ZIM files.
Memory implications might need to be looked into if we use the JNI to open multiple files at once. I am not too sure at the moment.