search

kiwix / kiwix-xulrunner

[ARCHIVED] Legacy Kiwix desktop solution for Windows/macOS/Linux
https://download.kiwix.org/release/kiwix-xulrunner/
GNU General Public License v3.0
112 stars 28 forks source link

Search box should be align on the right if UI uses a RTL language #370

Closed kelson42 closed 7 years ago

kelson42 commented 7 years ago

Currently it's alway aligned on the left.

mhutti1 commented 7 years ago

@kelson42 Do you mean that the text should be typed right to left when searching?

kelson42 commented 7 years ago

@mhutti1 the box itself should be on the right. But yes of course the text should be typed from right to the left (but this is maybe already the case).

mhutti1 commented 7 years ago

@kelson42 For me the box is on the right I think? Are you talking about content search, online search or file search?

kelson42 commented 7 years ago

screenshot

mhutti1 commented 7 years ago

screenshot

mhutti1 commented 7 years ago

It seems that long search bar can have the wrong text. But even short search bar when you type is the wrong way round.

EladKeyshawn commented 7 years ago

@mhutti1 On portrait the search box is aligned correctly, the problem is the box itself is not fully fit to the actionbar (it's at the middle).

kelson42 commented 7 years ago

@EladKeyshawn yes, this is an other bug... and @mhutti1 also discovered that (with last wikimed ar) makeing landscape-portrait-landscape puts the whole set of buttons on the wrong side (right), it should be left like at the beginning.... Seems we have a little bit work to do around this ;)

mhutti1 commented 7 years ago

http://www.phonearena.com/news/How-to-force-right-to-left-RTL-layouts-on-Android_id64154

This allows you to test in english.

mhutti1 commented 7 years ago

@kelson42 We could potential make a few GCI tasks out of this each to fix a part of the RTL layout. Now we can reproduce easily enough it should be in a students capability,

EladKeyshawn commented 7 years ago

@kelson42 I have not encountered this yet ;)

kelson42 commented 7 years ago

@mhutti1 Yes, split as much as you think this is necessary. Makes perfectly sense to me.

EladKeyshawn commented 7 years ago

@mhutti1 So you mean once the device is RTL and searching in LTR then I confirm its unaligned

mhutti1 commented 7 years ago

@EladKeyshawn I can see 3 bugs at the moment.

  1. Search is LTR 100% of the time once you start typing.
  2. If the search bar is large enough it can show LTR initially.
  3. If you switch orientation twice then you are reset to LTR.
EladKeyshawn commented 7 years ago

@mhutti1 For me when I set my device to Hebrew you can see when I type english it uses RTL. screenshot 06-13 26 2016

mhutti1 commented 7 years ago

@EladKeyshawn This doesn't happen for me. What device/os?

EladKeyshawn commented 7 years ago

@mhutti1 5.1 huawei mate s, but I checked on other apps like messanger and others and the behaviour is similar. So I dont think this is worth fixing.

kelson42 commented 7 years ago

This issue was moved to kiwix/kiwix-android#49