search

kiwix / kiwix-xulrunner

[ARCHIVED] Legacy Kiwix desktop solution for Windows/macOS/Linux
https://download.kiwix.org/release/kiwix-xulrunner/
GNU General Public License v3.0
112 stars 28 forks source link

Add context menu search to allow highlighted text to quickly be searched #398

Closed mhutti1 closed 7 years ago

mhutti1 commented 7 years ago

A user should be able to search a word by highlighting it and clicking "SEARCH KIWIX" as is currently achievable in the Wikipedia app. This should also work with custom apps as well.

screenshot_20161223-151527

EladKeyshawn commented 7 years ago

@mhutti1 I just noticed on the current context menu when you click the 3 dots for more, the menu background is white and the text can barely be seen.

EladKeyshawn commented 7 years ago

screenshot_2016-12-23-17-51-19

mhutti1 commented 7 years ago

@EladKeyshawn Thats strange. It looks fine for me. What device / os again?

EladKeyshawn commented 7 years ago

Huawei Mate S, 5.1. I have a feeling it has something to do with my device specifically.

mhutti1 commented 7 years ago

Yeah. I tested on another Huawei device and they had made a lot of changes from stock. I don't know if there's anything that we can do about this.

kelson42 commented 7 years ago

@mhutti1 What is the difference between "Search Wikipedia" and "Search Kiwix" ?

kelson42 commented 7 years ago

@EladKeyshawn @mhutti1 What is the status of the problem with Huawei?

mhutti1 commented 7 years ago

@kelson42 moved to new issue as unrelated to this. #415