Make it impossible to download twice a content on Android

[kelson42]

Steps:

• Open the "online" library
• Click on a content to download
• Comme back to the "online" library
• Click a second time on the same content

What we get:

• Content is still in the 'online' library
• Two downloads of the same content run in parallel

What we want:

• Content is removed from the 'online' library at the time the download start
• User is moved to the 'downloading' tab
• It's impossible to download twice a same content

[mhutti1]

@kelson42 I am struggling to reproduce this.

[EladKeyshawn]

@mhutti1 Are you on this ? I don't want to work twice 😉

[mhutti1]

@EladKeyshawn I can't reproduce it so Im not working on it.

[EladKeyshawn]

@mhutti1 really ? this is actually a bug that should occur on every device.

[mhutti1]

@EladKeyshawn Yeah I fixed it on my device and the emulator I have. So I thought I fixed it fully,

[EladKeyshawn]

@mhutti1 No need I fixed it. now pushing

[kelson42]

@EladKeyshawn Seems to perfectly works now :)

[kelson42]

@EladKeyshawn @mhutti1 This bug has re-appeared.

[EladKeyshawn]

Can you give me a specific Zim file with which it happens?

On Mon, Jan 2, 2017, 12:20 PM Kelson notifications@github.com wrote:

Reopened #403 https://github.com/kiwix/kiwix/issues/403.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kiwix/kiwix/issues/403#event-908899905, or mute the thread https://github.com/notifications/unsubscribe-auth/AQVJuYHIdGcZlvFs5nynti1WlVke3tcrks5rOM9ogaJpZM4LW3U8 .

[kelson42]

@EladKeyshawn I mostly test with both Wikimed (English) files

[EladKeyshawn]

Generally even without my patch the downloading files should no longer appear in the first place. So we I think it has to do with the most unique parameter separating those files. I took the full name of the Zim file. Maybe there are duplicates?

On Mon, Jan 2, 2017, 12:31 PM Kelson notifications@github.com wrote:

@EladKeyshawn https://github.com/EladKeyshawn I mostly test with both Wikimed (English) files

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kiwix/kiwix/issues/403#issuecomment-269955129, or mute the thread https://github.com/notifications/unsubscribe-auth/AQVJuRmMJ8Bzmzp8Ld1AJUSLn26LFNRXks5rONHmgaJpZM4LW3U8 .

[kelson42]

@EladKeyshawn ZIM file should be identified by there UID, not by there title or filename

[EladKeyshawn]

Yes but I'm not sure we save that in the DB I need to check

On Mon, Jan 2, 2017, 1:04 PM Kelson notifications@github.com wrote:

@EladKeyshawn https://github.com/EladKeyshawn ZIM file should be identified by there UID, not by there title or filename

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kiwix/kiwix/issues/403#issuecomment-269958552, or mute the thread https://github.com/notifications/unsubscribe-auth/AQVJuYdyfs3hTcV7kb8MUBPc-JYjDrnxks5rONnTgaJpZM4LW3U8 .

[mhutti1]

@kelson42 Can you give a more specific reproduction case for this?

[kelson42]

@mhutti1 @EladKeyshawn If I try to download quickly the two Wikimed (in English) ZIM files, only one disappear from the "online" tab. Even by trying to download the "bollywood" file, it often does not disappear from the "online" tab.

[mhutti1]

@kelson42 How about now?

[kelson42]

@mhutti1 Looks good now :)