search

kiwix / kiwix-xulrunner

[ARCHIVED] Legacy Kiwix desktop solution for Windows/macOS/Linux
https://download.kiwix.org/release/kiwix-xulrunner/
GNU General Public License v3.0
111 stars 28 forks source link

TTS feature totally disapeared from action menu (in git master) #411

Closed kelson42 closed 7 years ago

kelson42 commented 7 years ago

@rashiq @EladKeyshawn @mhutti1 Any idea?

EladKeyshawn commented 7 years ago

@kelson42 Yeah, yesterday I had it too, I though it occurred only to me. after clearing data it came back.

kelson42 commented 7 years ago

@EladKeyshawn What do you mean with "clearing data"? I do not think we can ask our users to do so? What is the trigger for this disappearance?

EladKeyshawn commented 7 years ago

@kelson42 I still don't know of course this is not something we should ask users, I just tried to see if it temporarily solves the problem. P.S after the TTS came back I also had issues with it like there was no stop option or after I clicked stop it kept playing.

EladKeyshawn commented 7 years ago

There were changes lately that might have caused this.

kelson42 commented 7 years ago

OK, this is important we identify the problem. We have currently people complaining about the TTS system and I can not test it at all ;(

mhutti1 commented 7 years ago

I should have fixed the button issue (another android lifecycle issue). @EladKeyshawn If you can reproduce the other issues and they havn't been fixed can you open another issue.

kelson42 commented 7 years ago

@EladKeyshawn @mhutti1 For me everything works fine back, so @EladKeyshawn we need you to tell us if the pause/stop buttons works fine.

EladKeyshawn commented 7 years ago

@kelson42 @mhutti1 I'm still experiencing the problem. Reproduction: 1) start TTS from menu 2) stop TTS also from menu TTS keeps running and is unstoppable.

Tell me if this occurs only on my device.

mhutti1 commented 7 years ago

@EladKeyshawn I can't reproduce on my phone. I can reproduce on emulator though.

mhutti1 commented 7 years ago

@kelson42 @EladKeyshawn So the problem was that our UtteranceListener was not being reset on versions of android before 6.0. It seems .stop() resets it in 6.0+ but doesn't pre 6.0 I have simply added code to manually reset it and this fixes on my emulator.

kelson42 commented 7 years ago

@EladKeyshawn @mhutti1 Nice together work :)

EladKeyshawn commented 7 years ago

👍