search

kiwix / kiwix-xulrunner

[ARCHIVED] Legacy Kiwix desktop solution for Windows/macOS/Linux
https://download.kiwix.org/release/kiwix-xulrunner/
GNU General Public License v3.0
111 stars 28 forks source link

Patch for making kiwix-serve compile #446

Closed godane closed 7 years ago

godane commented 7 years ago

This is a patch from kiwix-tools since it was fixed there: http://pastebin.com/GxnuBmer

Without this compiling kiwix-serve will fail.

kelson42 commented 7 years ago

@godane Which compiler (version) do you use? What are the errors you get?

mgautierfr commented 7 years ago

Thanks @godane for this patch.

Can you create a PR ? (And ideally make a reference to kiwix/kiwix-tools@5cfbda12 in the commit message).

godane commented 7 years ago

@kelson42 I used the code from this repo. Full error i got is here: http://pastebin.com/eMa56dvk

@mgautierfr Yes thats where i got the patch. Sorry about that.

kelson42 commented 7 years ago

@godane May you please make a merge request for your fix?

kelson42 commented 7 years ago

@godane @mgautierfr I have fixed manually. @godane thx.