search

kiwix / kiwix-xulrunner

[ARCHIVED] Legacy Kiwix desktop solution for Windows/macOS/Linux
https://download.kiwix.org/release/kiwix-xulrunner/
GNU General Public License v3.0
111 stars 28 forks source link

Unable to open the list of Bookmarks #455

Closed kelson42 closed 7 years ago

kelson42 commented 7 years ago

Nothing happens if I make a long click on the star icon.

mhutti1 commented 7 years ago

@kelson42 This was implemented in ece41dab94943dc80541578bd6e1b249ba83c740. @rashiq can you elaborate on why you think it is bad UX and suggest an alternative?

kelson42 commented 7 years ago

@mhutti1 I just see that a new "Bookmarks" entry has been put to the menus. Maybe we can have both? Would you be able to just bring back the "long click" behaviour?

rashiq commented 7 years ago

For me this is an anti pattern, since no other app uses it. Therefore most users wouldn't even know it's there (since they are not used to trying out this gesture).

kelson42 commented 7 years ago

@rashiq any disadvantage of having both (menu entry && long click)?

rashiq commented 7 years ago

Nope not that I could think of. We can add it back, I just thought it's not being used either way by anyone (due to the previously outlined nature of this being anti-pattern).

mhutti1 commented 7 years ago

Ok. So I have re added but I do agree that we should rethink how users interact with bookmarks to be more intuitive.

kelson42 commented 7 years ago

@mhutti1 thx