kiwix / libkiwix

Common code base for all Kiwix ports
https://download.kiwix.org/release/libkiwix/
GNU General Public License v3.0
118 stars 56 forks source link

Kiwix frontend style cleanup #1009

Closed veloman-yunkan closed 11 months ago

veloman-yunkan commented 11 months ago

Addresses #917

Unfortunately, I failed to achieve consistent look-and-feel across the library page and the viewer toolbar so that they both look nice.

This PR simply reduces the gap in the look-and-feel of the two toolbars. If we want to eliminate it completely, I think that we must come up with a new design first.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.92%. Comparing base (a5db4a1) to head (29c33a7). Report is 219 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1009 +/- ## ======================================= Coverage 38.92% 38.92% ======================================= Files 58 58 Lines 3990 3990 Branches 2201 2201 ======================================= Hits 1553 1553 Misses 1090 1090 Partials 1347 1347 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kelson42 commented 11 months ago

@veloman-yunkan Thank you for this PR and this attempt to fix this annoying issue. I know this is not easy. Will give it a test this WE.