kiwix / libkiwix

Common code base for all Kiwix ports
https://download.kiwix.org/release/libkiwix/
GNU General Public License v3.0
112 stars 55 forks source link

Test iOS cross-compile in CI #1018

Closed kelson42 closed 7 months ago

kelson42 commented 8 months ago

Test macOS to iOS cross-compilation in CI

kelson42 commented 8 months ago

@mgautierfr @rgaudin meson_cross_file.txt seems to be missing. An other point is that if we really need -Db_coverage=true here?!

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (24faf84) 38.88% compared to head (c5088aa) 38.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1018 +/- ## ======================================= Coverage 38.88% 38.88% ======================================= Files 58 58 Lines 3991 3991 Branches 2204 2204 ======================================= Hits 1552 1552 Misses 1090 1090 Partials 1349 1349 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rgaudin commented 8 months ago

@mgautierfr @rgaudin meson_cross_file.txt seems to be missing. An other point is that if we really need -Db_coverage=true here?!

It's downloading https://tmp.kiwix.org/ci/deps2_macos_native_dyn_libkiwix.tar.xz which obviously (so I think) doesn't contain BUILD_iOS_xxxx/ folder (which would contain the cross file.

kelson42 commented 8 months ago

@rgaudin Thx, indeed!

Now it seems the libzim is not part of the deps! See https://github.com/kiwix/libkiwix/actions/runs/6835979771/job/18590377587?pr=1018#step:5:71

rgaudin commented 8 months ago

Changed libzim suffix to libkiwix but in fact we don't produce those deps for the other archs: macOS arm64 (not listed), iOS x86_64 and iOS arm64

The only macos deps2 we produce for libkiwix is deps2_macos_native_dyn_libkiwix.tar.xz

kelson42 commented 8 months ago

@mgautierfr Can we easi

The only macos deps2 we produce for libkiwix is deps2_macos_native_dyn_libkiwix.tar.xz

@mgautierfr Can we easily fix this?