search

kiwix / libkiwix

Common code base for all Kiwix ports
https://download.kiwix.org/release/libkiwix/
GNU General Public License v3.0
118 stars 56 forks source link

Control characters are escaped in suggestions JSON #1023

Closed veloman-yunkan closed 10 months ago

veloman-yunkan commented 10 months ago

Fixes #1020

The fix is tested using only a unit test for the helper utility. No test running on real ZIM data is provided (because the problematic case is hardly represented in our test ZIM data).

codecov[bot] commented 10 months ago

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 38.88%. Comparing base (a959800) to head (571c09e). Report is 192 commits behind head on main.

Files with missing lines Patch % Lines
src/tools/otherTools.cpp 16.66% 0 Missing and 10 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1023 +/- ## ========================================== - Coverage 38.92% 38.88% -0.04% ========================================== Files 58 58 Lines 3990 3991 +1 Branches 2201 2204 +3 ========================================== - Hits 1553 1552 -1 Misses 1090 1090 - Partials 1347 1349 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kelson42 commented 10 months ago

Merging PR as pretty trivial and we need to release 13.0.0 now