search

kiwix / libkiwix

Common code base for all Kiwix ports
https://download.kiwix.org/release/libkiwix/
GNU General Public License v3.0
112 stars 55 forks source link

Cleanup of error response generation #1030

Closed veloman-yunkan closed 7 months ago

veloman-yunkan commented 7 months ago

This PR contains preparatory cleanup work before implementing translation of error pages (#1019).

codecov[bot] commented 7 months ago

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (f8aae39) 38.88% compared to head (5f27b4b) 38.95%.

Files Patch % Lines
src/server/internalServer.cpp 0.00% 6 Missing and 34 partials :warning:
src/server/response.cpp 63.63% 0 Missing and 12 partials :warning:
src/server/internalServer_catalog.cpp 0.00% 2 Missing and 6 partials :warning:
src/server/i18n.h 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1030 +/- ## ========================================== + Coverage 38.88% 38.95% +0.07% ========================================== Files 58 58 Lines 3991 3958 -33 Branches 2204 2181 -23 ========================================== - Hits 1552 1542 -10 + Misses 1090 1086 -4 + Partials 1349 1330 -19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kelson42 commented 7 months ago

@mgautierfr Good to merge?