kiwix / libkiwix

Common code base for all Kiwix ports
https://download.kiwix.org/release/libkiwix/
GNU General Public License v3.0
112 stars 55 forks source link

Default UI language is resolved in the frontend #1044

Closed veloman-yunkan closed 5 months ago

veloman-yunkan commented 5 months ago

Fixes #1038 Fixes #1039

This change makes the viewer resolve the default UI language in the front end, without any dependence on the backend's handling of the Accept-Language header. Yet, the latter has not been removed since it is currently used in the following scenarios:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (aff801e) 39.34% compared to head (c697611) 39.35%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1044 +/- ## ======================================= Coverage 39.34% 39.35% ======================================= Files 58 58 Lines 4061 4060 -1 Branches 2237 2236 -1 ======================================= Hits 1598 1598 Misses 1091 1091 + Partials 1372 1371 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

veloman-yunkan commented 5 months ago

Reminder to myself - translatewiki PR #1033 has been merged, so languages.js must be regenerated during rebase&fixup.

mgautierfr commented 5 months ago

Please rebase-fixup.

veloman-yunkan commented 5 months ago

Reminder to myself - translatewiki PR #1033 has been merged, so languages.js must be regenerated during rebase&fixup.

Done

veloman-yunkan commented 5 months ago

Please rebase-fixup.

@mgautierfr Done