Closed veloman-yunkan closed 5 months ago
Attention: 17 lines
in your changes are missing coverage. Please review.
Comparison is base (
795fcb9
) 39.35% compared to head (34cd553
) 39.36%.
Files | Patch % | Lines |
---|---|---|
src/search_renderer.cpp | 15.78% | 0 Missing and 16 partials :warning: |
src/server/internalServer.cpp | 0.00% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@veloman-yunkan I guess its time to rebase this PR.
@veloman-yunkan I guess its time to rebase this PR.
@kelson42 You are right. I could sense the same recommendation in my horoscope for today and humbly complied with it.
Fixes #1028
Contrary to https://github.com/kiwix/libkiwix/pull/1032#issuecomment-1896002341, no front-end side translation is performed on the search results page. Instead the
/search
endpoint is called with theuserlang
query parameter explicitly provided. The downside is the reduced opportunity for HTTP-caching search requests coming from users using different UI languages.Currently no real translations of messages related to search results are available. To test this change you will have to use the
test
language that is excluded from the UI language selector. It can be set by adding (once)?userlang=test
after/viewer
in the browser address bar.Known issues: