search

kiwix / libkiwix

Common code base for all Kiwix ports
https://download.kiwix.org/release/libkiwix/
GNU General Public License v3.0
112 stars 54 forks source link

Enter polyfills.js #1054

Closed veloman-yunkan closed 4 months ago

veloman-yunkan commented 4 months ago

Fixes #1051

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6b05eeb) 41.03% compared to head (4ee10ad) 39.36%. Report is 1 commits behind head on main.

:exclamation: Current head 4ee10ad differs from pull request most recent head 3ac36e8. Consider uploading reports for the commit 3ac36e8 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1054 +/- ## ========================================== - Coverage 41.03% 39.36% -1.67% ========================================== Files 58 58 Lines 4187 4075 -112 Branches 2303 2245 -58 ========================================== - Hits 1718 1604 -114 - Misses 1003 1091 +88 + Partials 1466 1380 -86 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

veloman-yunkan commented 4 months ago

I only tested that it didn't break my fresh Firefox (didn't test it on older browsers).

kelson42 commented 4 months ago

@veloman-yunkan @Jaifroid Can we do anything to secure it works before merging? @mgautierfr Why the CI fails on macOS?

Jaifroid commented 4 months ago

Well once this is merged to dev I could test with an older browser. It wouldn't be a tragedy to have a follow-up, remedial PR if necessary, so long as buggy code doesn't end up on the production server.

mgautierfr commented 4 months ago

@mgautierfr Why the CI fails on macOS?

Fixed with #1056 (This PR is rebased on new master).