search

kiwix / libkiwix

Common code base for all Kiwix ports
https://download.kiwix.org/release/libkiwix/
GNU General Public License v3.0
118 stars 56 forks source link

NameMapper detects (and reports) all naming conflicts #1067

Closed veloman-yunkan closed 7 months ago

veloman-yunkan commented 7 months ago

This PR demonstrates and addresses some issues with name mapping that were discovered while working on kiwix/kiwix-tools#596.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.05%. Comparing base (ddde6db) to head (068555d). Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
src/name_mapper.cpp 45.45% 0 Missing and 6 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1067 +/- ## ========================================== + Coverage 41.03% 41.05% +0.01% ========================================== Files 58 58 Lines 4187 4190 +3 Branches 2303 2304 +1 ========================================== + Hits 1718 1720 +2 Misses 1003 1003 - Partials 1466 1467 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.