search

kiwix / libkiwix

Common code base for all Kiwix ports
https://download.kiwix.org/release/libkiwix/
GNU General Public License v3.0
112 stars 54 forks source link

Testing of `books.name` and `books.filter.name` book selection methods in /search API #1068

Closed veloman-yunkan closed 4 months ago

veloman-yunkan commented 4 months ago

In the kiwix-serve's /search API there are two confusingly similar filtering parameters books.name and books.filter.name. Their effect on book selection is very different from what one might expect from their names. This PR demonstrates the difference via unit tests.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.07%. Comparing base (a8368b3) to head (e3fffd9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1068 +/- ## ========================================== + Coverage 41.05% 41.07% +0.02% ========================================== Files 58 58 Lines 4190 4190 Branches 2304 2304 ========================================== + Hits 1720 1721 +1 + Misses 1003 1001 -2 - Partials 1467 1468 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.