search

kiwix / libkiwix

Common code base for all Kiwix ports
https://download.kiwix.org/release/libkiwix/
GNU General Public License v3.0
112 stars 54 forks source link

Fix wrong usage of `extra_link_args` variable. #1092

Closed mgautierfr closed 1 month ago

mgautierfr commented 1 month ago

Previous PR #1074 remove a bit too much in meson.build around extra_libs, extra_link_args. So the compilation on Windows was failing. This PR fixes that.

The question about host_machine/build_machine should probably better handled but it will be once we will have a proper native compilation on Windows (soon™️). This PR is just making compilation of libkiwix works on Windows.

mgautierfr commented 1 month ago

Failing CI is https://ci.appveyor.com/project/Kiwix/kiwix-build/builds/49940697 Working CI (fixed) is https://ci.appveyor.com/project/Kiwix/kiwix-build/builds/49942262

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.87%. Comparing base (a1ce3d1) to head (01b9441).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1092 +/- ## ======================================= Coverage 40.87% 40.87% ======================================= Files 58 58 Lines 4223 4223 Branches 2313 2313 ======================================= Hits 1726 1726 Misses 1024 1024 Partials 1473 1473 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.