search

kiwix / libkiwix

Common code base for all Kiwix ports
https://download.kiwix.org/release/libkiwix/
GNU General Public License v3.0
112 stars 54 forks source link

Backward compatible support for IPv6 #1093

Closed veloman-yunkan closed 3 weeks ago

veloman-yunkan commented 1 month ago

This PR brings backward compatibility to #1074

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.36%. Comparing base (ae4b652) to head (75bddbf).

Files Patch % Lines
src/tools/networkTools.cpp 64.70% 1 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1093 +/- ## ========================================== + Coverage 40.87% 41.36% +0.49% ========================================== Files 58 58 Lines 4223 4233 +10 Branches 2313 2316 +3 ========================================== + Hits 1726 1751 +25 + Misses 1024 994 -30 - Partials 1473 1488 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

veloman-yunkan commented 3 weeks ago

Maybe we can also set the "old" methods as deprecated

It may be too soon. The nature of the enhancement is such that I feel fine with the old API staying around for some time. We can deprecate it later.