[fixes]ZIM size being advertized inconsistently between MB and MiB

kiwix / libkiwix

Common code base for all Kiwix ports

https://download.kiwix.org/release/libkiwix/

GNU General Public License v3.0

112 stars 54 forks source link

[fixes]ZIM size being advertized inconsistently between MB and MiB #1096

Closed harsha-mangena closed 1 week ago

harsha-mangena commented 2 weeks ago

Fixes https://github.com/kiwix/libkiwix/issues/1095

Switched from decimal (MB) to binary (MiB) units for file sizes
Used powers of 1024 instead of 1000 for size calculations
Adjusted precision to display up to 3 significant digits
Updated unit labels to KiB, MiB, GiB, TiB
Implemented log2-based calculation for determining appropriate unit

kelson42 commented 2 weeks ago

@harsha-mangena Thank you for your PR but please complete your PR by updating the cacheid (read the README for the details).

kelson42 commented 1 week ago

@veloman-yunkan Thx for the cacheid. Good to merge?

veloman-yunkan commented 1 week ago

@harsha-mangena Thanks for the PR!

I improved the commit message as well as changed the formatting of the size value (the fractional part is presented so as to ensure at least 3 significant digits). I also updated the cacheids in the unit tests.