search

kiwix / libkiwix

Common code base for all Kiwix ports
https://download.kiwix.org/release/libkiwix/
GNU General Public License v3.0
112 stars 55 forks source link

Move to c++17. #996

Closed mgautierfr closed 10 months ago

mgautierfr commented 10 months ago

All our compilers should handle c++17. Let's move on.

Following of openzim/libzim#819 Fix #877

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage has no change and project coverage change: +0.04% :tada:

Comparison is base (bde737f) 38.87% compared to head (983105c) 38.92%.

:exclamation: Current head 983105c differs from pull request most recent head c38ab3e. Consider uploading reports for the commit c38ab3e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #996 +/- ## ========================================== + Coverage 38.87% 38.92% +0.04% ========================================== Files 58 58 Lines 4000 4008 +8 Branches 2200 2204 +4 ========================================== + Hits 1555 1560 +5 + Misses 1101 1099 -2 - Partials 1344 1349 +5 ``` [see 4 files with indirect coverage changes](https://app.codecov.io/gh/kiwix/libkiwix/pull/996/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kiwix)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kelson42 commented 10 months ago

@mgautierfr You mean fixes #877 ?