Closed veloman-yunkan closed 1 year ago
Patch coverage: 50.00%
and project coverage change: -0.03%
:warning:
Comparison is base (
c6456ca
) 38.89% compared to head (cc6aa9b
) 38.87%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think that this PR introduced a small problem - now the text on error pages will be in the language detected from the value of the "Accept-Language" header (since the information about the user-selected language is no longer sent to the server).
@veloman-yunkan can you please open a new ticket? maybe provide a fix?
@veloman-yunkan can you please open a new ticket?
Done (#1019)
Fixes #995
A known issue with this fix is that the relatively expensive handling of the "Accept-Language" header is now being performed for all requests (unless the user language is explicitly specified in the URL query:
?userlang=...
). I will fix it after this PR clears all other hurdles of the review process.