kiwix / operations

Kiwix Kubernetes Cluster
http://charts.k8s.kiwix.org/
5 stars 0 forks source link

http://demo.hotspot.kiwix.org should redirect to https://demo.hotspot.kiwix.org #183

Closed kelson42 closed 2 months ago

kelson42 commented 2 months ago

The reasons are IMHO:

rgaudin commented 2 months ago

I disagree. This is a replica of the hotspot product which works exactly like this: you access it via HTTP and there is no redirect to HTTPs. I don't see what SEO has to do with this given we want to exclude it from search results. As for the Zimit1 scenario, it has the advantage of showing how it works on the hotspot (kind of the point of the demo!). The “bad impression” is due to the ZIM itself, not the hotspot.

We can obviously do it technically but:

So please reconsider and let me know you final decision. Change would be in container-images so it will require recreating an image for it to apply anyway.

kelson42 commented 2 months ago

@rgaudin If something does not work smoothly it should not be in the demo. Maybe we should just not put Zimit1 stuff in it as this is anyway not readable in the field?

rgaudin commented 2 months ago

that's my opinion as well

benoit74 commented 2 months ago

Content fixed by @Popolechien to not include zimit1 stuff.

Popolechien commented 2 months ago

I've removed the zimit1 content but I am not sure it solved the initial http-> httpsissue

benoit74 commented 2 months ago

It did not solved http -> https issue because there is no issue, the demo is replicating exactly the hotspot behavior (where there is no redirection)

Popolechien commented 2 months ago

Yeah the issue was not really one (I'd side with @rgaudin on this) but I wanted to flag it nonetheless.

rgaudin commented 2 months ago

I've opened https://github.com/offspot/demo/issues/7 for the side effect that got @Popolechien to open another issue.