search

kiwiz / gkeepapi

An unofficial client for the Google Keep API.
MIT License
1.52k stars 112 forks source link

correct sort argument's type annotation when adding a subitem to a list #136

Closed wizpig64 closed 1 year ago

wizpig64 commented 1 year ago

The sort argument for adding a top-level item to a list, List.add(), is annotated to accept both int and NewListItemPlacementValue values.

However, the sort argument for adding a sub-item to an existing item, ListItem.add(), is only annotated to accept int, which is making my type checker question my authority. It must be silenced.

This PR corrects that by adding the NewListItemPlacementValue option to the annotation.

🚀🚀🚀🚀🚀🚀🚀

kiwiz commented 1 year ago

Thanks, updated deprecate_py2 branch as well.