kiwiz / gkeepapi

An unofficial client for the Google Keep API.
MIT License
1.53k stars 114 forks source link

Update WebLink to allow missing title and description #153

Closed jkitching closed 10 months ago

jkitching commented 10 months ago

Google Assistant's note and list system has been moved to Google Keep: https://support.google.com/keep/?p=migrated_from_assistant

These items are annotated with a webLink that looks like this:

  {
    "webLink": {
      "kind": "notes#webLink",
      "url": "https://support.google.com/keep/?p=migrated_from_assistant",
      "provenanceUrl": "https://support.google.com/keep/?p=migrated_from_assistant",
      "hasThumbnailUrl": true
    }
  }

Previously, it was assumed that "name" and "description" are guaranteed to be supplied in a webLink annotation. However, this is no longer the case. This commit updates the WebLink class accordingly, and adds a test case.

Fixes #152.

kiwiz commented 10 months ago

Thanks! Uploaded 0.15.1.

jkitching commented 10 months ago

Thanks for the rapid merge and all the work you have put into this awesome project!

On Tue, Dec 12, 2023, 14:31 Kai @.***> wrote:

Thanks! Uploaded 0.15.1.

— Reply to this email directly, view it on GitHub https://github.com/kiwiz/gkeepapi/pull/153#issuecomment-1851381904, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5RFYFSQ2ATX6NVBV6KADYI7225AVCNFSM6AAAAABAQAPA3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJRGM4DCOJQGQ . You are receiving this because you authored the thread.Message ID: @.***>