search

kixelated / moq-rs

Rust library for Media over QUIC
Apache License 2.0
355 stars 53 forks source link

filter DNS query results to only include addresses that our quic endpoint can use #166

Closed Xaeroxe closed 1 month ago

Xaeroxe commented 1 month ago

Minor bug fix. Without this change it's possible that the connection will attempt to use an IP address which the internal quinn::Endpoint can't actually connect to.

Xaeroxe commented 1 month ago

I went ahead and fixed the clippy warning. I also adjusted the "context" of the error to more accurately reflect the actual problem.

kixelated commented 1 month ago

Yo, reverting this because it breaks production. I think the moq-pub client binds via ipv6 but connects to a ipv4 address, which should still be valid?

kixelated commented 1 month ago

But yeah the IPv4 vs IPv6 stuff is a mess.

Xaeroxe commented 1 month ago

I suspect I didn’t account for the IPV6_V6ONLY flag being set to false. The default value for this flag varies by operating system.

This would be easier if moq-rs created the quinn::Endpoint internally rather than accepting one from the caller.

kixelated commented 1 month ago

I suspect I didn’t account for the IPV6_V6ONLY flag being set to false. The default value for this flag varies by operating system.

This would be easier if moq-rs created the quinn::Endpoint internally rather than accepting one from the caller.

moq-native creates the quinn::Endpoint, because yeah it's a bit advanced to create your own.