search

kiyo-masui / bitshuffle

Filter for improving compression of typed binary data.
Other
219 stars 76 forks source link

ci: build macOS wheels #116

Closed jrs65 closed 2 years ago

jrs65 commented 2 years ago

@kiyo-masui I figured I should actually get someone to review this (although the last few changes I pushed through myself such that everything wasn't quite so broken). If you want to try the mac binary wheels you can get them here (https://github.com/kiyo-masui/bitshuffle/actions/runs/2016851429) just download the "artifact".

kiyo-masui commented 2 years ago

Looked at the changes, and while I'm out of date on how the build system and CI works, nothing looks wrong to me.

I downloaded the wheels on my laptop and had no trouble getting them to work and pass all the tests (well, one failed because I didn't have h5dump installed, but after I installed it everything worked).

jrs65 commented 2 years ago

Great. I'll merge it now and make a new release which means that PyPI will get the wheels. I'm looking forward to not needing to wait for bitshuffle to build every time I build a new virtualenv!