search

kiyo-masui / bitshuffle

Filter for improving compression of typed binary data.
Other
215 stars 76 forks source link

Drop the LZ4 dependency from bitshuffle.c #31

Closed maropu closed 8 years ago

maropu commented 8 years ago

Currently, bitshuffle.c has the lz4 dependency, that is, it includes lz4.h. This bit-shuffling technique is very useful for other LZ-variant libraries such as gzip and snappy, so many other developers of these kinds could exploit bit-shuffling functionality only. However, the dependency possibly makes these developers got stuck because of the unnecessary lz4 dependency. I tried to make codes to remove this and the codes is here. Could you give me any comment on this?

kiyo-masui commented 8 years ago

Sorry for taking so long to comment on this, as I was on vacation last week.

I agree that we should separate out the independent functionality. However, the proposed name changes, namely 'bitshuffle" -> "bshuf_lz4", is an unnecessary API change.

I propose the following: in your version rename "bshuf_lz4" to "bitshuffle" and "bitshuffle" to "bitshuffle_core". I know that this isn't the ideal naming scheme, but it preserves backward compatibility.

maropu commented 8 years ago

Okay, great! I'm actually being on vacation, so I'll fix the point you mentioned this weekend:))