search

kiyo-masui / bitshuffle

Filter for improving compression of typed binary data.
Other
215 stars 76 forks source link

Changes to allow compilation of bitshuffle C code with VS2008. #51

Closed vasole closed 8 years ago

vasole commented 8 years ago

These changes are needed in order to make the bitshuffle code compatible with VS2008. Basically one has to replace stdint.h and, in the functions, make the type declarations prior to the other statements.

kiyo-masui commented 8 years ago

This looks good!

One flaw in my .h files that only becomes obvious now: I think only bitshuffle_core.h needs to include stdint.h or have the typedef statements. bitshuffle.h and bishuffle_core.cpp both include this file. bitshuffle_internals.h could also include it. This probably also applies to other include statements.

Do you mind stripping these out?

vasole commented 8 years ago

I have stripped the includes from bitshuffle.c and bitshuffle.h

In bitshuffle_internals.h seems necessary to keep it in case one uses C++.