Add a condition for GNU c++ in bitshuffle_core.h

kiyo-masui / bitshuffle

Filter for improving compression of typed binary data.

Other

219 stars 76 forks source link

Add a condition for GNU c++ in bitshuffle_core.h #59

Closed maropu closed 7 years ago

maropu commented 7 years ago

We got an exception to compile bitshuffle v0.3.1 with g++(https://github.com/xerial/snappy-java/pull/163). This pr fixed this issue.

maropu commented 7 years ago

If this resolved, is it possible to release a newer bitshuffle?

kiyo-masui commented 7 years ago

This doesn't build (see the CI log above).

bitshuffle_core.h should not include bitshuffle_internals.h. The whole point is that bitshuffle_core.h only includes the public interface. Instead, the typedefs should be in bitshuffle_core.h, which bitshuffle_internals.h will then need to include. Both should be included in bitshuffle_core.c.

The build fail has something to do with the type defs, hopefully doing this more carefully sorts it out.

maropu commented 7 years ago

Oh, my bad. I'll check again.

maropu commented 7 years ago

How about the latest fix?

kiyo-masui commented 7 years ago

That simplifies things!

I'll merge it now, and release a bit later today.

maropu commented 7 years ago

Many thanks!!

kiyo-masui commented 7 years ago

Released. Enjoy.