search

kiyo-masui / bitshuffle

Filter for improving compression of typed binary data.
Other
215 stars 76 forks source link

License issues #9

Closed FrancescAlted closed 10 years ago

FrancescAlted commented 10 years ago

I am the author of the Blosc compression library (http://blosc.org), and I have just seen your work on bitshuffle, which I find pretty nice. I might be interested in including your code in Blosc, but bitshuffling choosing GPL chokes with MIT used in Blosc.

Would you like to change bitshuffling license so that parts of your code could be easily included in other MIT/BSD projects?

Thanks!

kiyo-masui commented 10 years ago

I will absolutely look in into changing the license.

Very happy that you are interested.

Kiyo On Aug 28, 2014 3:47 AM, "FrancescAlted" notifications@github.com wrote:

I am the author of the Blosc compression library (http://blosc.org), and I have just seen your work on bitshuffle, which I find pretty nice. I might be interested in including your code in Blosc, but bitshuffling choosing GPL chokes with MIT used in Blosc.

Would you like to change bitshuffling license so that parts of your code could be easily included in other MIT/BSD projects?

Thanks!

— Reply to this email directly or view it on GitHub https://github.com/kiyo-masui/bitshuffle/issues/9.

FrancescAlted commented 10 years ago

Thanks for considering this.

kiyo-masui commented 10 years ago

Would the LGPL work for you? My understanding is that this would allow you to: 1. distribute verbatim copies of Bitshuffle (or parts thereof) with Blosc, and 2. compile them into a single binary, all without affecting the Blosc licensing. It would require that any changes made to Bitshuffle be released under the LGPL, which would most practically be done by making the changes upstream.

FrancescAlted commented 10 years ago

I am afraid LGPL would be undesirable for my purposes. This has been discussed many times in the numpy/scipy mailing lists, and the outcome was that, for including external code, they require non-LGPL licenses:

http://wiki.scipy.org/License_Compatibility

Blosc is meant to be part of the numpy/scipy ecosystem, so I would prefer a license in the style of MIT/BSD, as stated above. Would that be possible? Thanks.

kiyo-masui commented 10 years ago

Addressed in version in pull request #10 and release 0.1.3.

FrancescAlted commented 10 years ago

Excellent. Thank you!

BTW, the c-blosc project, despite being a general library, also provides an HDF5 interface, so feel free to send PRs there in case you are interested.

FrancescAlted commented 9 years ago

It took a while, but a preliminary backport of the bitshuffle to c-blosc is here: https://github.com/Blosc/c-blosc/pull/146

Thanks again!

kiyo-masui commented 9 years ago

This looks great. Hopefully your users find it useful.

Kiyo

FrancescAlted commented 9 years ago

The port is completed now (with runtime detection for AVX2, so that you can run AVX2-enhanced binaries on non AVX2 machines) and merged in master. There are still some loosing ends, but should be eventually addressed in the future.

And I am definitely sure that there will be users that will find this very useful :)