search

kiyoka / fuzzy-string-match

fuzzy string matching library for ruby
Apache License 2.0
285 stars 39 forks source link

separate compile and build flags #8

Closed piavlo closed 12 years ago

kiyoka commented 12 years ago

Thanks for your pull request. I saw same error, when I modify my local source like, 

  builder.add_compile_flags '-x c++'
                                          # '-lstdc++'

So, i think your fix may be correct. This is error messages.

~/work/github/fuzzy-string-match $ rake test ruby -I ./lib which rspec -b ./test/basic_native_spec.rb Ffuzzy-string-match Warning: FuzzyStringMatch.new.create() is obsolute, please use FuzzyStringMatch.create() ... .

Failures:

1) FuzzyStringMatch when some string distances (Native) are should Failure/Error: @jarow.getDistance( "henka", "henkan" ).should be_within(0.0001).of(0.9722) NoMethodError: undefined method `getDistance' for #

./test/basic_native_spec.rb:31:in`block (2 levels) in <top (required)>'

 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/example.rb:87:in `instance_eval'
 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/example.rb:87:in`block in run'
 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/example.rb:195:in `with_around_each_hooks'
 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/example.rb:84:in`run'
 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/example_group.rb:353:in `block in run_examples'
 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/example_group.rb:349:in`map'
 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/example_group.rb:349:in `run_examples'
 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/example_group.rb:335:in`run'
 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/command_line.rb:28:in `block (2 levels) in run'
 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/command_line.rb:28:in`map'
 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/command_line.rb:28:in `block in run'
 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/reporter.rb:34:in`report'
 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/command_line.rb:25:in `run'
 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/runner.rb:69:in`run'
 # /usr/local/stow/ruby-1.9.3-p194/lib/ruby/gems/1.9.1/gems/rspec-core-2.10.0/lib/rspec/core/runner.rb:10:in `block in autorun'

Finished in 0.01386 seconds 2 examples, 1 failure

Failed examples:

rspec ./test/basic_native_spec.rb:30 # FuzzyStringMatch when some string distances (Native) are should rake aborted! Command failed with status (1): [ruby -I ./lib which rspec -b ./test/basi...]

piavlo commented 12 years ago

Can you push the new version to rubygems?

Thanks

piavlo commented 12 years ago

Can you push the new version to rubygems?

Thanks

kiyoka commented 12 years ago

OK. I'll push it.

kiyoka commented 12 years ago

I just pushed 0.9.4 to rubygems. Please check it.