Handle more than one "window" (tab) when starting browser - Githubissues

kiyoon / jupynium.nvim

Selenium-automated Jupyter Notebook that is synchronised with NeoVim in real-time.

MIT License

486 stars 15 forks source link

Handle more than one "window" (tab) when starting browser #60

Closed vandalt closed 1 year ago

vandalt commented 1 year ago

This fixes #59 by recording the initial number of tabs opened and waiting until the number of tabs equals the initial number or the initial number + 1. This is more general behaviour which checked only for equality with 1, which meant that if a profile opened tab by default, or if an extension did so, there would be a timeout error.

I tested on the following case:

A "blank" profile that has a single tab and keeps a single tab (default expected behaviour)
A profile with an extension that opens a second tab as newtab (so initial number is 2)
A profile with a pinned tab that opens automatically (so that initial number is 2, or 3 if an extension opens a new tab)

EDIT: Added cases I tested.

kiyoon commented 1 year ago

Thanks for the PR and also leaving a very nice documentation!