Closed matthewsia98 closed 1 year ago
Thanks for the PR! However, this defeats one principle of this plugin: all settings must be Jupynium's vim plugin version agnostic.
Since this plugin should interact with multiple instances of neovim, sometimes even remote ones over SSH, this plugin operates a little bit in a special way: it should run even without installing the vim plugin (and only using the python package pip install jupynium
).
The benefits of this approach are:
There are four things that should be modified from here.
pcall(require( ... ))
to bypass errors when the jupynium module is not found.lines
to markdown_lines
lua/jupynium/options.lua
's M.default_opts
as well. You can leave the default option in the helpers.lua
file in case the plugin is not installed and the pcall require
fails.:JupyniumKernelHover
)We can also make the option grouped to the kernel hover just in case in the future there are different types of floating windows we may use, and different options that may be added for hover (like timeout etc.). And name it floating_win_opts
to make it more clear what it does.
require("jupynium").setup({
kernel_hover = {
floating_win_opts = {
border = "rounded",
},
},
})
I'd prefer if we use kernel_hover.floating_win_opts
than floating_win_opts.hover
because there might be more settings for hover.
Also, can you add max_width = 84
in the default as well?
I think it's ready to be merged if you have no more comments!
I think it's ready to be merged if you have no more comments!
all good from me
I really appreciate this PR!
Allow users to configure floating win for
:JupyniumKernelHover
by passingwin_options
key in setup