search

kizniche / Mycodo

An environmental monitoring and regulation system
http://kylegabriel.com/projects/
GNU General Public License v3.0
2.94k stars 492 forks source link

pylint is taking way too much time in Analyzing the code #1249

Closed summa-code closed 1 year ago

summa-code commented 1 year ago

On edge devices with low processing powers, pylint is taking way too much time. Is there a way to configure this such that I can enable/disable warnings and others ? I think that Errors are the most important thing for edge devices.

Not sure if I can contribute, but is there a specific place in the code that I can try and play around a little bit ?

kizniche commented 1 year ago

I agree that modules that use pylint (Conditional Functions, Python Code Input, etc.), being able to disable the use of pylint would be a good addition. It will simply need the addition of a checkbox option to enable/disable and the corresponding check where pylint is executed. This is either in the single-file modules (in the case of inputs) but will be dispersed in various places for the Conditional Function.

summa-code commented 1 year ago

That would be a great addition. Currently, the page does not show any output to that effect that it is being analyzed. And if they close before the results come in, they loose the changes, even though they clicked on the save button.

kizniche commented 1 year ago

I agree, a status message indicating it's processing is also a good idea. I'll see if I can implement it soon.

kizniche commented 1 year ago

I just added the option to Analyze with Pylint to modules that use Python code (Inputs, Outputs, and Conditional Functions) in https://github.com/kizniche/Mycodo/commit/705664fe27eeb194c97d37d014da363895a1247b.

kizniche commented 1 year ago

This issue has been mentioned on Radical DIY Forum. There might be relevant details there:

https://forum.radicaldiy.com/t/mycodo-v8-15-0-release/1362/1