search

kizu / bemto

Smart mixins for writing BEM in Pug
439 stars 66 forks source link

Remove an attribute from tag if its value is false #71

Closed jonscottclark closed 8 years ago

jonscottclark commented 8 years ago

I recently upgraded to bemto 1.0, and realized that if I passed literal false to an attribute, bemto would convert it into the string "false" and the attribute would be present, which isn't the default Jade behaviour. See here: https://github.com/pugjs/jade/issues/240#issuecomment-17875875

Tested this fix and it seemed to restore the default expected behaviour.

kizu commented 8 years ago

Thanks! Merged and published as bemto.jade@1.0.2

jonscottclark commented 8 years ago

Excellent :) Thank you for the speed @kizu !