search

kj-9 / sqltools-redshift-driver

redshift driver for vscode sqltools extention
MIT License
4 stars 1 forks source link

Include External Schemas in connection tree view #1

Closed r4nyc closed 2 years ago

r4nyc commented 3 years ago

Currently it appears that the tree view is only showing local schemas (The schemas you get back from the query "SELECT * FROM svv_redshift_schemas")

It would be very helpful to include external schemas as well. External schemas are commonly used to expose data in other databases or the Glue Hive Meta store. https://docs.aws.amazon.com/redshift/latest/dg/r_CREATE_EXTERNAL_SCHEMA.html

You can get the combined list of schemas with the query SELECT FROM svv_all_schemas Or you can just get the external schemas SELECT FROM svv_external_schemas

kj-9 commented 3 years ago

Sorry for my late reply and I closed this issue by mistake...

As you mentioned, it may be not hard work to show external tables by adjusting some queries. Currently, I'm refactoring to make this repository as a single code base for the redshift driver, and after that I'll work on this topic.

kj-9 commented 3 years ago

Repoen this issue.

r4nyc commented 3 years ago

No need to apologize. I’m very grateful for the work you’re doing.

From: @.> Sent: Saturday, April 3, 2021 11:40 PM To: @.> Cc: @.>; @.> Subject: Re: [kj-9/vscode-sqltools] Include External Schemas in connection tree view (#1)

Sorry for my late reply and I closed this issue by mistake...

As you mentioned, it may be not hard work to show external tables by adjusting some queries. Currently, I'm refactoring to make this repository as a single code base for the redshift driver, and after that I'll work on this topic.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkj-9%2Fvscode-sqltools%2Fissues%2F1%23issuecomment-812965472&data=04%7C01%7C%7C882fe97f7a7943cb448a08d8f71b5a44%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637531044132895763%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=hSg0J771NtG4VPNYMoErHKEyHc2MWmJsmqkkmIMOiug%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAC67JP4VIY2JA2ETHOGRIA3TG7NRXANCNFSM4ZNRJXNQ&data=04%7C01%7C%7C882fe97f7a7943cb448a08d8f71b5a44%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637531044132905719%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=DV93QSKqPo1AUXW5r4576dhp5Wf%2Bpn6HmhekyWFPYIk%3D&reserved=0.

pbayerle commented 2 years ago

hello, curious if there are any updates as to when this will be resolved :slightly_smiling_face:

kj-9 commented 2 years ago

Hi @pbayerle . Sorry for my late reply.

I'm currently don't have much time to fix this issue. So, sorry again I can't tell you when to be resolved. If you could help this issue, a PR is appreciated.

peterbayerle commented 2 years ago

Hello, I just created a PR addressing this issue. I tested this locally and everything seems to work. I'm not sure how to search for schemas and tables in SQL tools (am I using an old version of the extension?) but changed the queries associated with this search functionality, too.

kj-9 commented 2 years ago

Thank you so much for the very quick response @peterbayerle ! I tested this in my environment and worked well.

I merged #2 and I will publish this feature as v0.0.3 soon.

kj-9 commented 2 years ago

I just published v0.0.3. please check out. Thanks again for huge help @peterbayerle !

peterbayerle commented 2 years ago

happy to help @kj-9! I use this tool every day at work and am happy to continue making contributions in my spare time