search

kjanoudi / joiful-react-forms

Automatically generate validated React forms using the Joi schema!
10 stars 1 forks source link

Remove autobind-decorator #26

Closed jaulz closed 8 years ago

jaulz commented 8 years ago

Please remove the autobind-decorator from the dependencies. Instead simply use the following in the constructor: this.getStateFromProps = this.getStateFromProps.bind(this)

If you don't like this please set it at least as a dependency and not as a dev dependency. Currently it triggers an exception and requires a manual installation of autobind-decorator.

bentatum commented 8 years ago

I agree. Do you mind submitting a PR?

jaulz commented 8 years ago

Great! Please see: https://github.com/kjanoudi/joiful-react-forms/pull/27

bentatum commented 8 years ago

On second thought, you shouldn't need autobind-decorator as a dependency.. (I could be wrong)

bentatum commented 8 years ago

@kjanoudi thoughts?

jaulz commented 8 years ago

At least the dist version on npm contains this:

var _autobindDecorator = require('autobind-decorator');

This is obviously not installed because it is a dev dependency.

bentatum commented 8 years ago

Yeah, you're totally right.